Visualize wireframes #314
Merged
Visualize wireframes #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Atharva Pusalkar <[email protected]>
ahcorde
approved these changes
May 3, 2021
| // create visual | ||
| VisualPtr visual = scene->CreateVisual(); | ||
| ASSERT_NE(nullptr, visual); | ||
|
|
There was a problem hiding this comment.
Suggested change
| EXPECT_EQ(false, visual->Wireframe()); | |
Signed-off-by: Atharva Pusalkar <[email protected]>
ahcorde
approved these changes
May 4, 2021
|
@osrf-jenkins retest this please |
Signed-off-by: Atharva Pusalkar <[email protected]>
|
Changed scene name to "scene7" since "scene6" is used in |
ahcorde
approved these changes
May 5, 2021
|
@osrf-jenkins retest this please |
1 similar comment
|
@osrf-jenkins retest this please |
|
The Camera test failure is unrelated |
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: |
WilliamLewww
pushed a commit
to WilliamLewww/ign-rendering
that referenced
this pull request
Dec 7, 2021
* Add wireframe mode Signed-off-by: Atharva Pusalkar <[email protected]> * Fix visual test Signed-off-by: Atharva Pusalkar <[email protected]> * Change scene name Signed-off-by: Atharva Pusalkar <[email protected]> Signed-off-by: William Lew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Atharva Pusalkar [email protected]
🎉 New feature
Summary
Adds wireframe mode to visuals in OGRE 1 and 2. This PR targets Ignition Fortress since the changes break the ABI.
OGRE 2
OGRE 1
Test it
Test it with wireframes.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge