Merge main branch into Ogre 2.2 and fixes

[darksylinc]

🦟 Bug fix

• Merged main branch into Ogre 2.2 branch
  • Rather do this now than later, while I still have fresh in my mind the code written for the main branch
• Restored FSAA (this bug affected main branch as well, but another minor bug in 2.2 branch prevented the fixes from main branch from working). Also went for explicit resolve route which was planned from the start, so that VRAM saving feature could be implemented.
• Save VRAM if FSAA is used + no postprocessing. This optimization is exclusive to Ogre 2.2+
  • This feature deprecates another overload of UpdateRenderPassChain
• Fix bug where changing background colour would not take immediate effect unless the compositor was rebuilt. See changes to Ogre2RenderTarget::UpdateBackgroundColor
• Removed Clear plasses in favour of LoadActions, which are more efficient in modern GPUs

I apologize for this monolith of a PR. There were many fixes and improvements to implement which relied on merging main -> 2.2 and this merge causes too many conflicts to easily split this into multiple smaller PRs.

All ign-rendering tests are passing.

Summary

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[codecov]

Codecov Report

Merging #359 (c19ec56) into ahcorde/update/ogre2.2 (970d862) will increase coverage by 0.03%.
The diff coverage is 93.83%.

@@                    Coverage Diff                     @@
##           ahcorde/update/ogre2.2     #359      +/-   ##
==========================================================
+ Coverage                   57.99%   58.03%   +0.03%     
==========================================================
  Files                         166      166              
  Lines                       16528    16550      +22     
==========================================================
+ Hits                         9586     9605      +19     
- Misses                       6942     6945       +3     

Impacted Files	Coverage Δ
ogre2/src/Ogre2RenderTargetMaterial.cc	0.00% <ø> (ø)
ogre2/src/Ogre2RenderTarget.cc	85.53% <90.99%> (+0.82%)	⬆️
ogre2/src/Ogre2DepthCamera.cc	86.92% <95.45%> (-0.80%)	⬇️
ogre2/src/Ogre2GpuRays.cc	95.52% <100.00%> (ø)
ogre2/src/Ogre2ThermalCamera.cc	89.31% <100.00%> (ø)
src/Image.cc	76.92% <100.00%> (+3.01%)	⬆️
...e/ignition/rendering/base/BaseGaussianNoisePass.hh	100.00% <0.00%> (+3.33%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 970d862...c19ec56. Read the comment docs.

[darksylinc]

I've updated the PR with the suggested changes and removed code deprecated for ign-rendering5.

Now DCO bot says my tweets are unverified though Github disagrees; DCO bot is expecting me to use my github handle as username, for some reason.

Strange is, it had been working until now

[iche033]

Did some quick tests with a few worlds in ign-gazebo and seems to be working fine.

The ogre2_demo couldn't start though. I'm getting:

terminate called after throwing an instance of 'Ogre::InvalidParametersException'
  what():  OGRE EXCEPTION(2:InvalidParametersException): RenderTexture 'scene::RenderTexture(65435)0' must be resident! in GL3PlusRenderPassDescriptor::updateColourFbo at /home/osrf/code/ign-ogre_ws/src/ogre-next/RenderSystems/GL3Plus/src/OgreGL3PlusRenderPassDescriptor.cpp (line 223)
Aborted (core dumped)

[darksylinc]

Did some quick tests with a few worlds in ign-gazebo and seems to be working fine.

The ogre2_demo couldn't start though. I'm getting:

terminate called after throwing an instance of 'Ogre::InvalidParametersException'
  what():  OGRE EXCEPTION(2:InvalidParametersException): RenderTexture 'scene::RenderTexture(65435)0' must be resident! in GL3PlusRenderPassDescriptor::updateColourFbo at /home/osrf/code/ign-ogre_ws/src/ogre-next/RenderSystems/GL3Plus/src/OgreGL3PlusRenderPassDescriptor.cpp (line 223)
Aborted (core dumped)

Fixed. That slipped through my testing. I had to undo the VRAM saving code (reasons explained in the commit). It's just too much over-engineering to be worth it.

I thought it'd be easier as in, just flip a texture off and reroute a few nodes.

[iche033]

works well for me now! I think windows CI is not yet working for ogre 2.2. Otherwise, other builds look good.