Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 ➡️ 4 #398

Merged
merged 6 commits into from
Sep 9, 2021
Merged

3 ➡️ 4 #398

merged 6 commits into from
Sep 9, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-rendering3 to ign-rendering4

Branch comparison: ign-rendering4...ign-rendering3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 4 commits August 24, 2021 10:57
…rendering3) (#376)

* Set OGRE minimal version to 1.8. Warn on versions not supported.
 Flag USE_UNOFFICIAL_OGRE_VERSIONS to disable the warning for the
 experienced users.

Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 8, 2021
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Sep 8, 2021
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #398 (004d6ae) into ign-rendering4 (018d256) will not change coverage.
The diff coverage is 60.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering4     #398   +/-   ##
===============================================
  Coverage           55.91%   55.91%           
===============================================
  Files                 147      147           
  Lines               13981    13981           
===============================================
  Hits                 7817     7817           
  Misses               6164     6164           
Impacted Files Coverage Δ
include/ignition/rendering/Camera.hh 100.00% <ø> (ø)
include/ignition/rendering/Geometry.hh 100.00% <ø> (ø)
include/ignition/rendering/GpuRays.hh 0.00% <ø> (ø)
include/ignition/rendering/Light.hh 100.00% <ø> (ø)
include/ignition/rendering/Material.hh 100.00% <ø> (ø)
include/ignition/rendering/Mesh.hh 100.00% <ø> (ø)
include/ignition/rendering/RayQuery.hh 100.00% <ø> (ø)
include/ignition/rendering/RenderEngine.hh 100.00% <ø> (ø)
include/ignition/rendering/Scene.hh 0.00% <ø> (ø)
include/ignition/rendering/Storage.hh 25.00% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 018d256...004d6ae. Read the comment docs.

@chapulina chapulina merged commit a3679f4 into ign-rendering4 Sep 9, 2021
@chapulina chapulina deleted the chapulina/3_to_4 branch September 9, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants