Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More nullptr checking on visuals and base axis #486

Merged
merged 5 commits into from
Nov 5, 2021

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Needed by gazebosim/gz-sim#1105

Summary

A couple of these nullptr checks were needed by gazebosim/gz-sim#1105. While at it, I also went over Ogre2Visual and OgreVisual, added more nullptr checks, and reduced the diff between them.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added the bug Something isn't working label Nov 5, 2021
@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress labels Nov 5, 2021
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #486 (7fcfd45) into ign-rendering6 (056023a) will decrease coverage by 0.01%.
The diff coverage is 35.48%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-rendering6     #486      +/-   ##
==================================================
- Coverage           53.60%   53.58%   -0.02%     
==================================================
  Files                 194      194              
  Lines               19645    19669      +24     
==================================================
+ Hits                10530    10539       +9     
- Misses               9115     9130      +15     
Impacted Files Coverage Δ
ogre/src/OgreVisual.cc 22.96% <13.33%> (-0.43%) ⬇️
ogre2/src/Ogre2Visual.cc 84.96% <50.00%> (-4.30%) ⬇️
include/ignition/rendering/base/BaseAxisVisual.hh 94.82% <100.00%> (+0.09%) ⬆️
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 100.00% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 056023a...7fcfd45. Read the comment docs.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@chapulina chapulina merged commit 5a5cdf1 into ign-rendering6 Nov 5, 2021
@chapulina chapulina deleted the chapulina/6/axis_null branch November 5, 2021 21:31
@chapulina
Copy link
Contributor Author

Ticketed #488 for the ABI checker failure, it's not caused by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants