-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More nullptr checking on visuals and base axis #486
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
…tics/ign-rendering into chapulina/6/axis_null Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-rendering6 #486 +/- ##
==================================================
- Coverage 53.60% 53.58% -0.02%
==================================================
Files 194 194
Lines 19645 19669 +24
==================================================
+ Hits 10530 10539 +9
- Misses 9115 9130 +15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
Ticketed #488 for the ABI checker failure, it's not caused by this PR. |
🦟 Bug fix
Needed by gazebosim/gz-sim#1105
Summary
A couple of these nullptr checks were needed by gazebosim/gz-sim#1105. While at it, I also went over
Ogre2Visual
andOgreVisual
, added more nullptr checks, and reduced the diff between them.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸