View entity frames from the GUI #1105
Conversation
Signed-off-by: Louise Poubel <[email protected]>
chapulina
added
GUI
src/gui/plugins/visualization_capabilities/VisualizationCapabilities.cc
Outdated
Show resolved
Hide resolved
|
I wasn't able to turn off frame visualization. Would it be possible to show a frame name when the mouse hovers over the axis? |
|
@nkoenig , this is still a WIP, I started working on it because I needed it to debug a project. I opened the PR for visibility so we don't duplicate the work. I'll let you know when I'm able to clean it up and address comments.
It's in my TODO list
That would be a nice feature. I'll look into it when I come back to this PR and see if it's trivial to add. If it's not, I'll ticket an issue and leave it out of this PR's scope. |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
chapulina
added
the
needs upstream release
Fixed, it needs gazebosim/gz-rendering#486 |
Signed-off-by: Louise Poubel <[email protected]>
I made it always show the name, but it only works with Ogre 1. Do you think that's enough for a 1st iteration? |
Signed-off-by: Louise Poubel <[email protected]>
| /// \param[in] _entity Entity to find children | ||
| /// \return Vector of children found for the parent entity | ||
| public: std::unordered_set<ignition::gazebo::Entity> | ||
| FindChildFrames(const ignition::gazebo::Entity &_entity); |
There was a problem hiding this comment.
Is this something that should be in Util.cc?
There was a problem hiding this comment.
Yeah good point. It will need to be cleaned up and tested more. I ticketed an issue because there are other functions in this plugin in the same situation:
src/gui/plugins/visualization_capabilities/VisualizationCapabilities.cc
Outdated
Show resolved
Hide resolved
| // https://github.com/ignitionrobotics/ign-rendering/issues/487 | ||
| if (nullptr != textGeom) | ||
| { | ||
| textGeom->SetFontName("Liberation Sans"); |
There was a problem hiding this comment.
Other QML code uses Roboto is it possible to use Roboto here?
There was a problem hiding this comment.
Unfortunately we can only use fonts installed with ign-rendering. We should look into installing Roboto in the future: gazebosim/gz-rendering#512
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1105 +/- ##
===============================================
- Coverage 62.22% 61.96% -0.27%
===============================================
Files 276 276
Lines 22886 22991 +105
===============================================
+ Hits 14241 14246 +5
- Misses 8645 8745 +100
Continue to review full report at Codecov.
|
chapulina
removed
the
needs upstream release
🎉 New feature
Needs gazebosim/gz-rendering#486
Summary
View entity frames from the context menu. This is similar to Gazebo classic's functionality.
This is an alternative to gazebosim/gz-gui#182
Test it
For example:
ign gazebo log_record_dbl_pendulum.sdf -v 4 --render-engine ogre2Try models, links or visuals:
With Ogre 1, it's possible to see the frame names (see gazebosim/gz-rendering#487 for Ogre 2). But Ogre 1 doesn't support transparency, so it's hard to see the frames 🙃
ign gazebo log_record_dbl_pendulum.sdf -v 4 --render-engine ogreUsability considerations for the future:
While at it, I updated documentation and naming of some functions in
VisualizationCapabiitiesin the hope of making the usage clearer. I can split that into a separate PR if preferred.TODO
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸