Scale BaseAxis properly

[ahcorde]

While I was adding the origin axes to ignition gazebo I checked that the scale for a BaseAxis is wrong. Current implementation:

Overriding the scale methods:

Signed-off-by: ahcorde [email protected]

[codecov]

Codecov Report

Merging #88 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #88   +/-   ##
======================================
  Coverage    7.56%   7.56%           
======================================
  Files          26      26           
  Lines        1744    1744           
======================================
  Hits          132     132           
  Misses       1612    1612           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcd9c49...ca745c9. Read the comment docs.

[iche033]

I think you should be able to just override this version with math::Vector3d arg. The other two just calls this function so can be removed.

[iche033]

how about:

      for (unsigned int i = 0; i < this->ChildCount(); ++i)
        this->ChildByIndex(i)->SetLocalScale(_scale);

this way we don't need to declare the private xArrow, yArrow, zArrow variables

[ahcorde]

This PR builds on top of this other PR #87

[iche033]

looks good, updated change log in 71f4e44

[ahcorde]

there is an issue in one of the test https://build.osrfoundation.org/job/ignition_rendering-ci-pr_any-ubuntu_auto-amd64/623/testReport/junit/(root)/AxisVisual_AxisVisualTest/AxisVisual_ogre/

/var/lib/jenkins/workspace/ignition_rendering-ci-pr_any-ubuntu_auto-amd64/ign-rendering/src/AxisVisual_TEST.cc:65
Expected equality of these values:
 math::Vector3d(0.2, 0.3, 0.4)
   Which is: 0.2 0.3 0.4
 visual->LocalScale()
   Which is: 1 1 1

[ahcorde]

CI is green except on windows

[iche033]

tests on windows are not fully working yet so the failures are expected

[chapulina]

tests on windows are not fully working yet so the failures are expected

Just an FYI that the buildfarmer's script indicates that these 2 failures are new on Windows:

    AxisVisual/AxisVisualTest.AxisVisual/ogre
    ArrowVisual/ArrowVisualTest.ArrowVisual/ogre