Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test config to run ogre 1.x tests in ign-sensors6 on macOS #156

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 15, 2021

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Summary

see gazebosim/gz-rendering#407 for more info.
Switching to ogre 1.x on macos for ignition Fortress libraries

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #156 (0f7872a) into main (b73c6c7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   77.51%   77.51%           
=======================================
  Files          24       24           
  Lines        2326     2326           
=======================================
  Hits         1803     1803           
  Misses        523      523           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73c6c7...0f7872a. Read the comment docs.

@chapulina chapulina added beta Targeting beta release of upcoming collection macOS macOS support labels Sep 15, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've relaxed the requirement for homebrew to be green in order to merge PRs into main.

@chapulina chapulina merged commit 1014843 into main Sep 15, 2021
@chapulina chapulina deleted the ogre_test_macos branch September 15, 2021 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🏯 fortress Ignition Fortress macOS macOS support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants