Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test config to run ogre 1.x tests in ign-rendering6 on macOS #407

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 15, 2021

🦟 Bug fix

tests started failing after updating our ign-rendering6 homebrew formula to depend on ogre 2.2:
osrf/homebrew-simulation#1574

There should be some GL3+ support for ogre 2.2 on macOS as seen in:
OGRECave/ogre-next#209

But updated to run ogre 1.x tests until we have time to investigate the cause of failing tests on macOS.

I also fixed some clang warnings.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 15, 2021
@iche033 iche033 mentioned this pull request Sep 15, 2021
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #407 (ce889dd) into main (993bb0b) will not change coverage.
The diff coverage is n/a.

❗ Current head ce889dd differs from pull request most recent head 94dbc51. Consider uploading reports for the commit 94dbc51 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #407   +/-   ##
=======================================
  Coverage   58.65%   58.65%           
=======================================
  Files         174      174           
  Lines       17278    17278           
=======================================
  Hits        10134    10134           
  Misses       7144     7144           
Impacted Files Coverage Δ
ogre2/src/Ogre2DepthCamera.cc 87.10% <ø> (ø)
ogre2/src/Ogre2ThermalCamera.cc 89.51% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 993bb0b...94dbc51. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 failures is better than 42 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants