-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed windows warnings #58
Conversation
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-sensors4 #58 +/- ##
================================================
+ Coverage 76.00% 76.01% +0.01%
================================================
Files 23 23
Lines 2321 2322 +1
================================================
+ Hits 1764 1765 +1
Misses 557 557
Continue to review full report at Codecov.
|
Builds have more than 200 warning build on Windows (for example: https://build.osrfoundation.org/job/ign_sensors-pr-win/477/). This PR remove all of them |
Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Ian Chen <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Argh, I forgot that #59 still had 4
|
yeah I noticed that too. Looks like it's from RenderingSensor.cc but also didn't see why the pragmas didn't work there. I thought the easy way to fix it is to update ign-rendering.. |
Yeah I also thought this while working on gazebosim/gz-gui#112 and #59, but the number of warnings on |
I resolved conflicts after merging #60, hoping to see the windows build fixed, but it now has 4 new warnings from ign-rendering |
Signed-off-by: Louise Poubel <[email protected]>
Removed Windows warnings in ign-rendering gazebosim/gz-rendering#183 |
Do we need a ign-rendering release ? |
Thanks for picking that up again! 🙇♀️
I don't think that's needed, because we don't generate binaries for Windows. Let's retrigger CI |
Windows is green! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows is green!
Woohoo! ✔️ Glad you were here to witness this moment 😄
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
* Prepare fo 3.2.0 release (#94) Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Backport #60 from ign-sensors4 Fix macOS/windows tests that failed to load library (#60) * Add workflow for macos-latest * Set test env to help find plugins This fixes tests on macOS and windows that were failing to find and/or load a sensor component library. In windows CI and the macOS workflow (which runs `make test` before `make install`) tests were failing with the message "Unable to find sensor plugin path". This is fixed by setting the IGN_PLUGIN_PATH in cmake to the build folder containing the compiled plugins. In the macOS jenkins build (which runs `make test` after `make install`) tests were failing with the message "SDF sensor type does not match template type". It was difficult to track down, but it appears to be caused by a failure to properly dlopen all the shared libraries linked by the component plugins when a test finds an installed component library, rather than one from the build folder. It is fixed by setting DYLD_LIBRARY_PATH to include the location of the installed libraries. Fixes #4. * Remove redundant AddPluginPaths calls from tests They don't work on windows, so just depend on the environment variables set in cmake instead. Signed-off-by: Steve Peters <[email protected]> * 👩🌾 Clear Windows warnings (backport #58) (#102) Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> * Master branch updates (#106) Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Steve Peters <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: ahcorde [email protected]