Skip to content

Commit

Permalink
Docker fixes (#1238)
Browse files Browse the repository at this point in the history
docker tag ubuntu:latest test:$(date +%Y_%b_%d_%H%M)                  127 ↵
Error parsing reference: "test:2021_déc._07_2129" is not a valid repository/tag: invalid reference format

Signed-off-by: Pierre Kancir <[email protected]>
  • Loading branch information
khancyr authored Dec 7, 2021
1 parent f292777 commit 3dd811d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,25 +69,25 @@ distribution using debians.
**Steps**

1. Build a docker image using the `build.bash` command. The first argument
must be the name of the Ignition distribution. For example, to build an
image of Ignition Blueprint:
must be the name of the Ignition distribution. The list of Ignition distribution can be found at [Ignition distribution](https://ignitionrobotics.org/docs). For example, to build an
image of Ignition Fortress:

```
./build.bash ignition-blueprint ./Dockerfile.ignition
./build.bash ignition-fortress ./Dockerfile.ignition
```

2. Run the docker image using `run.bash`, and pass in the name of the docker
image (first argument to the build.bash script).

```
./run.bash ignition-blueprint
./run.bash ignition-fortress
```

3. You can pass arguments to Ignition Gazebo by appending them the
`run.bash` command. For example, to load the shapes.sdf file:

```
./run.bash ignition-blueprint -f shapes.sdf
./run.bash ignition-fortress -f shapes.sdf
```

## Appendix
Expand Down
2 changes: 1 addition & 1 deletion docker/build.bash
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ fi
user_id=$(id -u)
image_name=$1
dir_name=$(dirname $2)
image_plus_tag=$image_name:$(date +%Y_%b_%d_%H%M)
image_plus_tag=$image_name:$(date +%Y_%m_%d_%H%M)

docker build --rm -t $image_plus_tag --build-arg user_id=$user_id --build-arg ign_distribution=$1 -f $2 .
docker tag $image_plus_tag $image_name:latest
Expand Down

0 comments on commit 3dd811d

Please sign in to comment.