Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker fixs #1238

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Docker fixs #1238

merged 2 commits into from
Dec 7, 2021

Conversation

khancyr
Copy link
Contributor

@khancyr khancyr commented Dec 7, 2021

🦟 Bug fix

Fix unaccepted caracters on docker tagging :

docker tag ubuntu:latest test:$(date +%Y_%b_%d_%H%M)
Error parsing reference: "test:2021_déc._07_2129" is not a valid repository/tag: invalid reference format

using %b from date on a french computer output déc for December and the é isn't accepted on docker image tag.

Summary

The fix change the image tag to number only.
The second commit update the readme info to the latest Ignition distribution and give a link on where to find distribution name.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

docker tag ubuntu:latest test:$(date +%Y_%b_%d_%H%M)                  127 ↵
Error parsing reference: "test:2021_déc._07_2129" is not a valid repository/tag: invalid reference format

Signed-off-by: Pierre Kancir <[email protected]>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Dec 7, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chapulina chapulina merged commit 3dd811d into gazebosim:ign-gazebo6 Dec 7, 2021
@khancyr khancyr deleted the docker-fixs branch December 8, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants