-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System inspector GUI widget #1404
Conversation
Signed-off-by: Louise Poubel <[email protected]>
807d19b
to
8dcfb4f
Compare
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're aligned to the right, but I can see how that may not give the best result. Let me think a bit.
Argh I actually tried for a while and failed 😕 I'll give it another try. It looks to me that the background size is ignoring the font size. |
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1404 +/- ##
===============================================
- Coverage 63.49% 63.45% -0.05%
===============================================
Files 307 309 +2
Lines 24776 24828 +52
===============================================
+ Hits 15731 15754 +23
- Misses 9045 9074 +29
Continue to review full report at Codecov.
|
How about naming the menu item |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linters are failing
/github/workspace/include/ignition/gazebo/components/SystemPluginInfo.hh:36: Lines should be <= 80 characters long [whitespace/line_length] [2]
/github/workspace/src/gui/plugins/component_inspector/ComponentInspector.cc:483: Lines should be <= 80 characters long [whitespace/line_length] [2]
Otherwise LGTM
Signed-off-by: Louise Poubel <[email protected]>
Fixed in cdf4116 |
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1404 +/- ##
===============================================
- Coverage 33.58% 33.42% -0.17%
===============================================
Files 44 45 +1
Lines 2260 2271 +11
===============================================
Hits 759 759
- Misses 1501 1512 +11
Continue to review full report at Codecov.
|
🎉 New feature
Closes
Builds on top of
Summary
Add a way for the user to inspect which systems are loaded, and what their configuration is.
SystemInfo
component to hold information about systemsSystemManager
the moment the system is loaded. This makes sure that systems loaded at runtime from various code paths always get added.PluginV
messages, so a single component can hold information about multiple systemsTest it
ign gazebo diff_drive.sdf
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸