-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CMake version examples and bump plugin version #1442
Conversation
Not sure why the CI is breaking... It broke for the commit when I just had docs changes. |
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
eb16b45
to
a1d4b75
Compare
this will need to be merged to |
Is it an issue if CI seems to be failing? Required CI pass though.
https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-homebrew-amd64/8052/console |
that is unrelated to these changes |
Ok, I will merge so that we can carry on with the bump. Required CI is green and this is a relatively trivial change. |
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-releases-2022-04-27-fortress-citadel/1389/1 |
🦟 Bug fix
Related to: gazebo-tooling/release-tools#700
Summary
Use
*_VERSION_MAJOR
variables to aid search/replace scripts.Also bumps the version.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.