Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL in hydrodynamics tutorial #2280

Merged
merged 2 commits into from
Jan 6, 2024
Merged

Conversation

mabelzhang
Copy link
Contributor

@mabelzhang mabelzhang commented Jan 5, 2024

🦟 Bug fix

Summary

I think the automatic rebase from main to gz-sim8 in the original PR broke the old URL.

Also fix citation bug - the []() syntax is showing up as invalid links, so I added a space in between.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

I think the automatic rebase from `main` to `gz-sim8` in the original PR broke the old URL.

Signed-off-by: Mabel Zhang <[email protected]>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jan 5, 2024
Signed-off-by: Mabel Zhang <[email protected]>
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f677bf) 65.63% compared to head (4b3f745) 65.62%.

Additional details and impacted files
@@             Coverage Diff             @@
##           gz-sim8    #2280      +/-   ##
===========================================
- Coverage    65.63%   65.62%   -0.02%     
===========================================
  Files          324      324              
  Lines        30925    30925              
===========================================
- Hits         20298    20294       -4     
- Misses       10627    10631       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mabelzhang mabelzhang merged commit 82969d5 into gz-sim8 Jan 6, 2024
7 of 10 checks passed
@mabelzhang mabelzhang deleted the mabelzhang/fix_hydro_url branch January 6, 2024 00:57
rgov pushed a commit to rgov/gz-sim that referenced this pull request Jan 16, 2024
* Fix URL in hydrodynamics tutorial
* Fix citation bug
---------
Signed-off-by: Mabel Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants