Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.25.0 #358

Merged
merged 3 commits into from
Sep 18, 2020
Merged

2.25.0 #358

merged 3 commits into from
Sep 18, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Sep 17, 2020

I'm leaving out the log playback scrubber, and assuming that the log performance enhancements will get in.

Signed-off-by: Nate Koenig [email protected]

Signed-off-by: Nate Koenig <[email protected]>
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Sep 17, 2020
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #358 into ign-gazebo2 will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo2     #358      +/-   ##
===============================================
+ Coverage        77.85%   77.99%   +0.13%     
===============================================
  Files              186      186              
  Lines            10184    10184              
===============================================
+ Hits              7929     7943      +14     
+ Misses            2255     2241      -14     
Impacted Files Coverage Δ
src/SimulationRunner.cc 96.39% <0.00%> (+2.40%) ⬆️
src/network/PeerInfo.cc 100.00% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3a4719...582d703. Read the comment docs.

@chapulina
Copy link
Contributor

I think we can get #299 into this release, the CI is almost done there.

@nkoenig
Copy link
Contributor Author

nkoenig commented Sep 18, 2020

I think we can get #299 into this release, the CI is almost done there.

Are you thinking of merging #299 tonight?

@nkoenig
Copy link
Contributor Author

nkoenig commented Sep 18, 2020

I need to get this release out the door. I'll merge this and save the scrubber for another release.

@nkoenig nkoenig merged commit 471ebbf into ign-gazebo2 Sep 18, 2020
@nkoenig nkoenig deleted the nate/2-25-0-prep branch September 18, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants