Fixed material colors for Ackermann SDF files #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jenn Nguyen <[email protected]>
chapulina
approved these changes
Mar 24, 2021
azeey
approved these changes
Mar 24, 2021
chapulina
added
beta
|
Our Windows CI has a long queue right now. Since this shouldn't affect Windows, I cancelled that build. Merging with the current results! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jenn Nguyen [email protected]
🦟 Bug fix
Summary
There were several Ackermann SDF files that had invalid material color components (e.g.,
<diffuse>11 11 11</diffuse>). With the new changes from gazebosim/sdformat#519, this will fail. These invalid color components have been replaced with1 1 1.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge