Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Bullet on Edifice #919

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Support Bullet on Edifice #919

merged 2 commits into from
Jul 23, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Jul 17, 2021 •
edited
Loading

Signed-off-by: Louise Poubel [email protected]

🦟 Bug fix

Fixes gazebosim/gz-physics#273

Summary

Bullet doesn't support nested models, capsules or ellipsoids.

Test it

ign gazebo -v 3 rolling_shapes.sdf --physics-engine ignition-physics-bullet-plugin --force-version 5

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina
Support Bullet on Edifice
658c50c 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from azeey as a code owner July 17, 2021 02:42
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Jul 17, 2021
Blast545
Blast545 approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! CI seems to be failing on unrelated issues.

@chapulina chapulina merged commit 511287d into ign-gazebo5 Jul 23, 2021
@chapulina chapulina deleted the chapulina/5/bullet branch July 23, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blast545 Blast545 Blast545 approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@ahcorde ahcorde Awaiting requested review from ahcorde

Assignees
No one assigned
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bullet plugin does not work in Edifice
2 participants
@chapulina @Blast545