Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bullet plugin does not work in Edifice #273

Closed
diegoferigo opened this issue Jun 30, 2021 · 2 comments · Fixed by gazebosim/gz-sim#919
Closed

Bullet plugin does not work in Edifice #273

diegoferigo opened this issue Jun 30, 2021 · 2 comments · Fixed by gazebosim/gz-sim#919
Labels
bug Something isn't working 🏢 edifice Ignition Edifice

Comments

@diegoferigo
Copy link
Contributor

Environment

  • OS Version: Ubuntu 20.04
  • Source or binary build? Source at a20dbba and ign-gazebo 5.0 binaries (I suspect also the upcoming 5.1)

Description

  • Expected behavior: being able to load the bullet physics plugin in Edifice
  • Actual behavior: the Physics system fails with the following error:
[Wrn] Plugin [ignition::physics::bullet::Plugin] misses required features:
- N8ignition7physics26RemoveNestedModelFromModelE
[Err] Failed to load a valid physics engine from [/workspace/install/lib/ign-physics-4/engine-plugins/libignition-physics-bullet-plugin.so].

Additional details

  1. This new physics feature was introduced in Remove nested models #230.
  2. Bullet reached the Edifice branch in 3 ➡️ 4 #271.
  3. This new physics feature is part of:
    https://github.com/ignitionrobotics/ign-physics/blob/a20dbbab2bc4ed324fb3fddf060b674755234b27/include/ignition/physics/RemoveEntities.hh#L112-L115
  4. The RemoveEntities feature is part of MinimumFeatureList.

I think that currently bullet works in Dome, even though I didn't try it. However, in Edifice it seems that it cannot be loaded due to this missing feature.

cc @Lobotuerk @azeey

@chapulina
Copy link
Contributor

Oh I thought I had tried it with ign-gazebo when I did a1a8f8b. I guess I didn't 😕

We should update Gazebo's MinimumFeatureList to use RemoveModelFromWorld instead of RemoveEntities.

@chapulina chapulina added the 🏢 edifice Ignition Edifice label Jun 30, 2021
@azeey
Copy link
Contributor

azeey commented Jun 30, 2021

Yeah, I think RemoveNestedModelFromModel should be optional since ConstructSdfNestedModel is optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants