Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Light Plugin to work with MinimalScene #978

Closed
wants to merge 6 commits into from

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 18, 2021

Signed-off-by: ahcorde [email protected]

🎉 New feature

Summary

It allows to create lights inside the minimalScene. It still not working because of a racecondition when running in the same process

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde ahcorde self-assigned this Aug 18, 2021
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Aug 18, 2021
@ahcorde
Copy link
Contributor Author

ahcorde commented Aug 18, 2021

@chapulina
Copy link
Contributor

There's a lot of duplication between this and #979 . Do you think it could make sense to have a separate Spawn plugin that listens to the spawn events?

This way we probably won't need to update ResourceSpawner and BananaForScale.

@ahcorde
Copy link
Contributor Author

ahcorde commented Aug 19, 2021

superseded by #983

@ahcorde ahcorde closed this Aug 19, 2021
@ahcorde ahcorde deleted the ahcorde/light/minimal_scene branch August 19, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants