-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Spawn plugin #983
Added Spawn plugin #983
Conversation
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #983 +/- ##
==========================================
- Coverage 63.80% 63.78% -0.02%
==========================================
Files 246 246
Lines 20015 19996 -19
==========================================
- Hits 12771 12755 -16
+ Misses 7244 7241 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me! I just ran into a couple of issues:
-
When I click to insert, it looks like I selected an entity with an invalid ID:
-
While inserting multiple things, sometimes the hover would stop working, but I'm having a hard time reproducing
-
I got this exception on close:
[GUI] [Dbg] [MinimalScene.cc:343] Destroy scene [scene] terminate called after throwing an instance of 'Ogre::InternalErrorException' what(): OGRE EXCEPTION(7:InternalErrorException): MovableObject ID: 194, named 'double_pendulum_with_base_0::lower_link::vis_cylinder_scene::Cylinder(60560)' of type 'Item' Had it's mGlobalIndex out of date!!! (or the MovableObject wasn't created with this SceneManager) in SceneManager::checkMovableObjectIntegrity at /var/lib/jenkins/workspace/ogre-2.1-debbuilder/repo/OgreMain/src/OgreSceneManager.cpp (line 4365)
@chapulina I have a patch but I would like to merge this PR first #995 which is a fix in select entities plugin |
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
There are some new test failures that seem to be related to SDFormat, unrelated to this PR. |
🎉 New feature
Summary
It allows to create entities (models and lights) inside the minimalScene.
Require this PR gazebosim/gz-gui#273
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge