Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Spawn plugin #983

Merged
merged 8 commits into from
Sep 8, 2021
Merged

Added Spawn plugin #983

merged 8 commits into from
Sep 8, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 19, 2021

🎉 New feature

Summary

It allows to create entities (models and lights) inside the minimalScene.

Require this PR gazebosim/gz-gui#273

Test it

ign gazebo -r -v 4 minimal_scene.sdf

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #983 (f82ec2e) into main (f48085b) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head f82ec2e differs from pull request most recent head d93a125. Consider uploading reports for the commit d93a125 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #983      +/-   ##
==========================================
- Coverage   63.80%   63.78%   -0.02%     
==========================================
  Files         246      246              
  Lines       20015    19996      -19     
==========================================
- Hits        12771    12755      -16     
+ Misses       7244     7241       -3     
Impacted Files Coverage Δ
src/EntityComponentManager.cc 84.64% <0.00%> (-0.20%) ⬇️
src/SimulationRunner.cc 93.90% <0.00%> (-0.03%) ⬇️
...e/ignition/gazebo/detail/EntityComponentManager.hh 95.10% <0.00%> (+1.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f48085b...d93a125. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! I just ran into a couple of issues:

  1. When I click to insert, it looks like I selected an entity with an invalid ID:

    spawn_select

  2. While inserting multiple things, sometimes the hover would stop working, but I'm having a hard time reproducing

  3. I got this exception on close:

    [GUI] [Dbg] [MinimalScene.cc:343] Destroy scene [scene]
    terminate called after throwing an instance of 'Ogre::InternalErrorException'
      what():  OGRE EXCEPTION(7:InternalErrorException): MovableObject ID: 194, named 'double_pendulum_with_base_0::lower_link::vis_cylinder_scene::Cylinder(60560)' of type 'Item'
    Had it's mGlobalIndex out of date!!! (or the MovableObject wasn't created with this SceneManager) in SceneManager::checkMovableObjectIntegrity at /var/lib/jenkins/workspace/ogre-2.1-debbuilder/repo/OgreMain/src/OgreSceneManager.cpp (line 4365)
    

src/gui/plugins/spawn/Spawn.hh Outdated Show resolved Hide resolved
src/gui/plugins/spawn/Spawn.hh Outdated Show resolved Hide resolved
src/gui/plugins/spawn/Spawn.hh Outdated Show resolved Hide resolved
@ahcorde
Copy link
Contributor Author

ahcorde commented Aug 25, 2021

@chapulina I have a patch but I would like to merge this PR first #995 which is a fix in select entities plugin

@ahcorde ahcorde requested a review from chapulina August 27, 2021 09:31
@chapulina chapulina mentioned this pull request Sep 8, 2021
8 tasks
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor

There are some new test failures that seem to be related to SDFormat, unrelated to this PR.

@chapulina chapulina merged commit 1fb3207 into main Sep 8, 2021
@chapulina chapulina deleted the ahcorde/plugin/spawn branch September 8, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants