-
Notifications
You must be signed in to change notification settings - Fork 95
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix GSG violations on non-trivially destructible types (#1264)
* Types.hh, kSdfScopeDelimiter Signed-off-by: Aaron Chong <[email protected]> * use constexpr char for preferred_separator Signed-off-by: Aaron Chong <[email protected]> * parser_urdf, constexpr instead of const Signed-off-by: Aaron Chong <[email protected]> * ParticleEmitter, kEmitterTypeStrs Signed-off-by: Aaron Chong <[email protected]> * Camera, kPixelFormatNames Signed-off-by: Aaron Chong <[email protected]> * Sensor, kSensorTypeStrs Signed-off-by: Aaron Chong <[email protected]> * Types, kSdfScopeDelimiter, use string_view instead of char array Signed-off-by: Aaron Chong <[email protected]> * Revert changes to parser_urdf.cc Signed-off-by: Aaron Chong <[email protected]> * Added comment about size template parameter Signed-off-by: Aaron Chong <[email protected]> * Reverting mistake on double back slashes, and keeping static const char Signed-off-by: Aaron Chong <[email protected]> * Using NeverDestroyed for kSdfScopeDelimiter Signed-off-by: Aaron Chong <[email protected]> * Revert use of string_view for Sensor and Camera as macOS doesn't treat them as literals Signed-off-by: Aaron Chong <[email protected]> * Reverting to static const to hopefully appease win and macos Signed-off-by: Aaron Chong <[email protected]> * Fix implicit instantiate Signed-off-by: Aaron Chong <[email protected]> * Using const string_view this time Signed-off-by: Aaron Chong <[email protected]> * Suggestions for deprecating kSdfScopeDelimiter (#1265) Signed-off-by: Addisu Z. Taddese <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> Signed-off-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]>
- Loading branch information
1 parent
8a26cb4
commit e98fcd8
Showing
9 changed files
with
65 additions
and
35 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters