Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GSG violations on non-trivially destructible types #1264

Merged
merged 16 commits into from
Mar 31, 2023

Conversation

aaronchongth
Copy link
Collaborator

🦟 Bug fix

Fixes #552

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #1264 (cc7d3fe) into main (8a26cb4) will increase coverage by 0.00%.
The diff coverage is 92.59%.

❗ Current head cc7d3fe differs from pull request most recent head 75ceb7d. Consider uploading reports for the commit 75ceb7d to get more accurate results

@@           Coverage Diff           @@
##             main    #1264   +/-   ##
=======================================
  Coverage   87.20%   87.21%           
=======================================
  Files         126      126           
  Lines       16301    16304    +3     
=======================================
+ Hits        14216    14219    +3     
  Misses       2085     2085           
Impacted Files Coverage Δ
include/sdf/Types.hh 100.00% <ø> (ø)
src/Utils.cc 87.64% <0.00%> (ø)
src/Camera.cc 89.47% <50.00%> (ø)
src/Filesystem.cc 98.80% <100.00%> (ø)
src/ParticleEmitter.cc 92.23% <100.00%> (ø)
src/Sensor.cc 91.89% <100.00%> (ø)
src/Types.cc 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aaronchongth aaronchongth changed the title Aaron/gsg nontrivial destruct Fix GSG violations on non-trivially destructible types Mar 28, 2023
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the use of std::string_view. Much cleaner than trying to use const char*. The only main issue is how we tick-tock kSdfScopeDelimiter. Otherwise, LGTM!

include/sdf/Types.hh Outdated Show resolved Hide resolved
src/Sensor.cc Outdated Show resolved Hide resolved
src/Types.cc Outdated Show resolved Hide resolved
src/parser_urdf.cc Outdated Show resolved Hide resolved
src/Filesystem.cc Outdated Show resolved Hide resolved
@aaronchongth aaronchongth marked this pull request as ready for review March 30, 2023 09:14
include/sdf/Types.hh Outdated Show resolved Hide resolved
src/Camera.cc Outdated Show resolved Hide resolved
@aaronchongth aaronchongth merged commit e98fcd8 into main Mar 31, 2023
@aaronchongth aaronchongth deleted the aaron/gsg-nontrivial-destruct branch March 31, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants