-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python script to replace ruby xmlschema generator #1232
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1232 +/- ##
=======================================
Coverage 87.60% 87.60%
=======================================
Files 128 128
Lines 16830 16830
=======================================
Hits 14744 14744
Misses 2086 2086 |
121e0af
to
7c37a93
Compare
CI is failing with a permission denied message |
the power of |
shall we remove the ruby script it is replacing? |
Good with me. I noticed that the other PR doing this targeted main, so I will retarget this one. |
78348a1
to
8bc86b1
Compare
This brought other changes over from |
8bc86b1
to
f374bc4
Compare
Rebased, thanks. Note that we can't drop ruby entirely, because it will interfere with the CLI tests. |
Is there a reason why you didn't considered #643? |
Signed-off-by: Michael Carroll <[email protected]>
f374bc4
to
651bdf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! Just a few minor comments.
Signed-off-by: Michael Carroll <[email protected]>
@scpeters do you know what would be causing:
In the actions build here? |
Nevermind, this is the root error:
|
there was a fix in #1271 waiting to be forward ported to |
Signed-off-by: Addisu Z. Taddese <[email protected]>
I just cherry-picked the fix here. |
In conjunction with #884, this should allow us to remove the Ruby dependency from sdformat entirely.
I checked this against the output of the ruby generator, and all files matched with the exception of a small difference in physics: