-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USD to SDF: Initial commit #827
Conversation
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf12 #827 +/- ##
==========================================
- Coverage 88.65% 88.19% -0.46%
==========================================
Files 92 95 +3
Lines 14221 14525 +304
==========================================
+ Hits 12607 12811 +204
- Misses 1614 1714 +100
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the USD -> SDF converter has a different file structure than the SDF -> USD converter. The USD -> SDF converter has headers in usd/include/sdf/usd_parser
instead of usd/include/sdf/usd
, and source files are in usd/src/usd_parser
instead of usd/src
. I think it makes sense to separate the USD -> SDF and SDF -> USD header/source files, but what if we used the following file structure for both converters so that they are more aligned:
Have ausd/include/sdf/usd
directory, which is the "top level" header directory. SDF -> USD converter headers can be in theusd/include/sdf/usd/sdf_parser
directory, and USD -> SDF converter headers can be in theusd/include/sdf/usd/usd_parser
.Keep ausd/src
directory, which is the "top level" source directory. SDF -> USD converter sources can be in theusd/src/sdf_parser
directory, and USD -> SDF converter sources can be in theusd/src/usd_parser
directory.
Another option would be to have both converter header files in usd/include/sdf/usd
, and both converter source files in usd/src
, but this could make it difficult for users to know which files are associated with which parser.
If we decide to re-work the file structure to what I proposed above, then we would need to update the file structure in #817 before merging it.
File structure has been reworked in 2088f1e
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed all of the files yet, but I do have a few questions:
test/usd/empty_file.usda
is not used. Can this file be removed?- Can tests be added for the API in
UsdMaterial.hh
?
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
@osrf-jenkins retest this please |
@azeey do you mind to take another look to this pull request? |
ebfbc1f
to
3ae7fd9
Compare
…unit tests Signed-off-by: Ashton Larkin <[email protected]>
3ae7fd9
to
6ada66f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more minor comments. LGTM otherwise.
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: ahcorde <[email protected]>
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
Signed-off-by: ahcorde [email protected]
🎉 New feature
Summary
This PR is the initial commit to support the conversion between USD to SDF.
The two classes included here allow to load stage and get the relevant data such us:
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.