Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdf -> usd: Added sensor #830

Merged
merged 32 commits into from
Feb 25, 2022
Merged

sdf -> usd: Added sensor #830

merged 32 commits into from
Feb 25, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jan 26, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

Parse SDF sensor and convert them in USD

  • Camera
  • Lidar
  • IMU

Added test too

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde requested a review from adlarkin January 26, 2022 15:38
@ahcorde ahcorde self-assigned this Jan 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2022 •
edited
Loading

Codecov Report

Merging #830 (8903f48) into sdf12 (5e3605f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            sdf12     #830   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files          78       78           
  Lines       12636    12636           
=======================================
  Hits        11484    11484           
  Misses       1152     1152

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e3605f...8903f48. Read the comment docs.

@adlarkin adlarkin mentioned this pull request Jan 26, 2022
Closed
8 tasks
ahcorde and others added 3 commits January 26, 2022 23:10
@ahcorde
Fixed test
0a5a9a7 
Signed-off-by: ahcorde <[email protected]>
@ahcorde
Merge remote-tracking branch 'origin/ahcorde/sdf_to_usd_visuals' into…
04dc57d 
… ahcorde/sdf_to_usd_sensors
@adlarkin
review feedback
89daa0d 
Signed-off-by: Ashton Larkin <[email protected]>
@adlarkin adlarkin mentioned this pull request Feb 8, 2022
Closed
ahcorde and others added 9 commits February 10, 2022 17:10
@ahcorde
Fixed scale and submesh name
f0331ca 
Signed-off-by: ahcorde <[email protected]>
@ahcorde
Fixed laser pose and imu box size
8339c09 
Signed-off-by: ahcorde <[email protected]>
@ahcorde
Fixed test
6497f8e 
Signed-off-by: ahcorde <[email protected]>
@ahcorde
Merge remote-tracking branch 'origin/sdf12' into ahcorde/sdf_to_usd_l…
e85f60c 
…inks
@ahcorde
Use UsdError
a02a6e1 
Signed-off-by: ahcorde <[email protected]>
@adlarkin
codecheck, use USD component's visibility macro, properly construct w…
f898d26 
…rapped sdf errors

Signed-off-by: Ashton Larkin <[email protected]>
@adlarkin
Merge branch 'ahcorde/sdf_to_usd_links' into ahcorde/sdf_to_usd_visuals
258606c
@adlarkin
usd UsdErrors and USD component visibility
c43ba24 
Signed-off-by: Ashton Larkin <[email protected]>
@adlarkin
Merge branch 'sdf12' into ahcorde/sdf_to_usd_links
f816dd4
@adlarkin adlarkin mentioned this pull request Feb 15, 2022
Merged
7 tasks
@scpeters scpeters added the usd label Feb 21, 2022
Base automatically changed from ahcorde/sdf_to_usd_visuals to sdf12 February 24, 2022 09:42
adlarkin
adlarkin reviewed Feb 25, 2022
View reviewed changes
Copy link
Contributor

@adlarkin adlarkin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some updates in 10d7da1 and have one question, but other than that, LGTM!

usd/src/sdf_parser/Sensor.cc Outdated Show resolved Hide resolved
@ahcorde
Removed todo
8903f48 
Signed-off-by: ahcorde <[email protected]>
adlarkin
adlarkin approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scpeters or @azeey, would you like to take a look at this before we merge it?

scpeters
scpeters reviewed Feb 25, 2022
View reviewed changes
usd/src/sdf_parser/Sensor.cc Outdated Show resolved Hide resolved
usd/src/sdf_parser/Sensor.cc Outdated Show resolved Hide resolved
@ahcorde
Added feedback
48ad6a5 
Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde merged commit 4dd71a5 into sdf12 Feb 25, 2022
@ahcorde ahcorde deleted the ahcorde/sdf_to_usd_sensors branch February 25, 2022 22:06
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@adlarkin adlarkin adlarkin approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

Assignees

@ahcorde ahcorde

Labels
usd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ahcorde @codecov-commenter @osrf-triage @scpeters @adlarkin