Editor / Upload file or overview from main form #6371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework the overview manager to manage any kind of file upload.
The directive can also be embedded into the main form directly to manage overview or to easily upload files.
Files are upload in the data store and then a link is added with `WWW:DOWNLOAD` protocol by default or a custom value.
Examples:
```xml
Example for file upload in the main form
<section>
<field xpath="/gmd:MD_Metadata/gmd:identificationInfo//gmd:title"/>
* Manage overview
<directive data-gn-overview-manager=""/>
* Manage uploaded file with a WWW:DOWNLOAD protocol
<directive data-gn-file-uploader=""
data-type="onlines"/>
* Same but with custom titles and icons
<directive data-gn-file-uploader=""
data-title="Resource for download"
data-btn-label="Drop a file here"
data-icon="fa-cloud"
data-type="onlines"/>
* Without the panel
<directive data-gn-file-uploader=""
data-title=""
data-type="onlines"/>
* With a custom protocol
<directive data-gn-file-uploader=""
data-protocol="DIRECTDOWNLOAD"
data-type="onlines"/>
</section>
```
josegar74
reviewed
Jun 13, 2022
| class="gn-file-uploader"> | ||
| <div data-ng-if="panelMode" class="panel-heading" data-gn-slide-toggle> | ||
| <i class="fa fa-fw {{icon}}"></i> | ||
| <span data-translate="">{{title}}</span> |
There was a problem hiding this comment.
The overview panel with the change displays the header Download instead of Overview
| '/attachments?visibility=public', | ||
| dropZone: $('#gn-overview-dropzone'), | ||
| singleUpload: true, | ||
| // TODO: acceptFileTypes: /(\.|\/)(xml|skos|rdf)$/i, |
There was a problem hiding this comment.
This is something to improve: for thumbnails, only image formats should be allowed. For files, should be limited to certain types, maybe make both configurable in the settings?
Not in the scope of this pull request, but to create a ticket to track this.
There was a problem hiding this comment.
I tried to use https://github.com/blueimp/jQuery-File-Upload/wiki/Options#processqueue without success.
|
|
||
| * Same but with custom titles and icons | ||
| <directive data-gn-file-uploader="" | ||
| data-title="Resource for download" |
There was a problem hiding this comment.
Does this support translation keys?
There was a problem hiding this comment.
You could put text or a key that you can set in database translation.
josegar74
approved these changes
Jun 14, 2022
fxprunayre
added a commit
that referenced
this pull request
Jun 20, 2022
Follow up of #6371 * Cleanup styles to have same rendering of links in record view and editor (labels, icons) - Replace #6101 * Improve format encoding can use WWW:DOWNLOAD:{format} or a MimeFileType element in ISO standards. * Create directive for uploading file that can be used in various places (eg. metadata filestore or form file or thumbnail upload) * Upload file / Add file format to import eg. images only for thumbnails
fxprunayre
added a commit
that referenced
this pull request
Jul 6, 2022
…abels (#6411) * Online source / Improve format support Follow up of #6371 * Cleanup styles to have same rendering of links in record view and editor (labels, icons) - Replace #6101 * Improve format encoding can use WWW:DOWNLOAD:{format} or a MimeFileType element in ISO standards. * Create directive for uploading file that can be used in various places (eg. metadata filestore or form file or thumbnail upload) * Upload file / Add file format to import eg. images only for thumbnails * Online source / Improve format support / Wro4j errors. * Online source / Improve format support / Styling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the overview manager to manage any kind of file upload.
The directive can also be embedded into the main form directly to manage overview or to easily upload files.
Files are upload in the data store and then a link is added with
WWW:DOWNLOADprotocol by default or a custom value.Sample editor configuration for file upload in the main form: