Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online source / Improve format support and more homogeneous icons & labels #6411

Merged
merged 3 commits into from
Jul 6, 2022

Conversation

fxprunayre
Copy link
Member

Follow up of #6371

image

  • Editor associated resource manager

image

  • Record view

image

  • Improve format encoding can use WWW:DOWNLOAD:{format} or a MimeFileType element in ISO standards (We used to have this type of encoding in 2.x). Added support in both ISO19115-3 and ISO19139
               <gmd:onLine>
                  <gmd:CI_OnlineResource>
                     <gmd:linkage>
                        <gmd:URL>http://localhost:8080/geonetwork/srv/api/records/856f5230-62ad-4b9f-8e50-1972ae8859f2/attachments/byconformity.json</gmd:URL>
                     </gmd:linkage>
                     <gmd:protocol>
                        <gmx:MimeFileType type="json">WWW:DOWNLOAD</gmx:MimeFileType>
                     </gmd:protocol>
  • Create directive for uploading file that can be used in various places (eg. metadata filestore or form file or thumbnail upload)
  • Upload file / Add file format to import eg. images only for thumbnails (eg. logo manager only allows png files in file system browser)

Follow up of #6371

* Cleanup styles to have same rendering of links in record view and editor (labels, icons) - Replace #6101
* Improve format encoding can use WWW:DOWNLOAD:{format} or a MimeFileType element in ISO standards.
* Create directive for uploading file that can be used in various places (eg. metadata filestore or form file or thumbnail upload)
* Upload file / Add file format to import eg. images only for thumbnails
@fxprunayre fxprunayre added this to the 4.2.1 milestone Jun 20, 2022
@@ -0,0 +1,10 @@
<a data-ng-href="{{onlinesrcService.getApprovedUrl(link.lUrl)}}"

Check warning

Code scanning / CodeQL

Potentially unsafe external link

External links without noopener/noreferrer are a potential security risk.
@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@MichelGabriel MichelGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in Bolsena, looks ok to me.

@fxprunayre fxprunayre merged commit 4251707 into main Jul 6, 2022
@fxprunayre fxprunayre deleted the 421-linkmimetype branch July 20, 2022 07:03
fxprunayre added a commit that referenced this pull request Aug 10, 2022
Support protocol encoded using Anchor. Maybe related to INSPIRE encoding rules or to format encoding (see #6411). This configuration is used by the geopublication process mainly.
josegar74 pushed a commit that referenced this pull request Sep 8, 2022
Support protocol encoded using Anchor. Maybe related to INSPIRE encoding rules or to format encoding (see #6411). This configuration is used by the geopublication process mainly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants