Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard / ISO / Mimefiletype encoding. #7291

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Standard / ISO / Mimefiletype encoding. #7291

merged 1 commit into from
Aug 29, 2023

Conversation

fxprunayre
Copy link
Member

Do not switch encoding of protocol if mimetype is empty. Preserve CharacterString if no mimetype.

Not all users are using the format for online source link. So avoid to create empty mime file type:

               <mrd:onLine>
                  <cit:CI_OnlineResource>
                     <cit:linkage>
                        <gco:CharacterString>https://service.pdok.nl/kadaster/wkpb/atom/v1_0/index.xml</gco:CharacterString>
                     </cit:linkage>
                     <cit:protocol>
                        <gcx:MimeFileType type="">INSPIRE Atom</gcx:MimeFileType>
                     </cit:protocol>
                     <cit:name>
                        <gco:CharacterString>dadadada</gco:CharacterString>
                     </cit:name>
                  </cit:CI_OnlineResource>
               </mrd:onLine>

To test, edit an online resource and do not set the format.

#6411

Do not switch encoding of protocol if mimetype is empty.
Preserve CharacterString if no mimetype.
@fxprunayre fxprunayre added this to the 4.4.0 milestone Aug 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fxprunayre I've tested and doesn't add the element, when mimeType is empty, what is fine.

But it seems mimeType is not sent from the editor, so always seems to be empty, even if a distribution format is selected as a protocol.

@fxprunayre
Copy link
Member Author

But it seems mimeType is not sent from the editor, so always seems to be empty, even if a distribution format is selected as a protocol.

mimeType is set when you use a distribution format option

image

@fxprunayre fxprunayre merged commit 59c9b0e into main Aug 29, 2023
10 checks passed
@fxprunayre fxprunayre deleted the 440-mimefiletype branch September 19, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants