ref(server): Manually control concurrent upstream requests #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still to do: - consuming loop not done - figure out if we can do consuming loop somehow in the actor thread or we need to spanw thread ( and change request sender not to receive self)
RaduW
changed the title
- still missing free http connection counters
RaduW
force-pushed
the
ref/priority-upstream
branch
from
71f9123
to
7a1fd59
Compare
priority is type specific, not instance specific and therefore should not have &self in the signature of WithRequestPriority::priority()
Changed for interface legibility of.
RaduW
changed the title
jan-auer
requested changes
Aug 17, 2020
Instead of using an mpsc channel to notify the end of a tracked future now we use an `Recipient<TrackedFutureFinished>` with the handler implemented in `UpstreamRelay`
jan-auer
changed the title
jan-auer
approved these changes
Aug 18, 2020
jan-auer
added a commit
that referenced
this pull request
Aug 18, 2020
* master: fix: Coerce missing PR body to empty string meta(gh): Add a status check for changelogs (#700) ref(server): Manually control concurrent upstream requests (#678) fix(docs): Clarify sooner which mode to choose (#709) chore(config): Remove config for emitting attachment flags (#718) fix(protocol): Fix docs typo (#719) fix(doc): Add missing newlines (#717) ci(release): Add killswitch via issues w/ release-blocker label (#714) fix: Add changelog entry for #712 (#716)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP Move implementation from all upstream requests being sent when they are created
to sending them only when there are free http connections available.