meta(gh): Add a status check for changelogs #700
Conversation
dangerfile.ts
Outdated
| const isTrivial = (danger.github.pr.body + danger.github.pr.title).includes('#trivial'); | ||
|
|
||
| if (!hasChangelog !hasPyChangelog && !isTrivial) { | ||
| warn('Please add a changelog entry in either CHANGELOG.md or py/CHANGELOG.md, or add #trivial to the PR title.'); |
There was a problem hiding this comment.
Instead of the title, can we make it a comment or the PR description?
There was a problem hiding this comment.
I copypasted this from the javascript repo and thought i'd add an instructional msg -- turns out it does use both title and body
|
@jan-auer tried out github actions over hackweek. it's better. should I move this dangerjs stuff into gha as well? |
|
@untitaker yes, i think that would make a lot of sense. Do you see a way to get this working for external contributions as well? Ideally, this works on all PRs similar to all those license bots. |
|
Update: You can just use the github action integration documented here:
|
|
So it seems that GHA is not really running here, not sure what to do |
jan-auer
changed the title
* master: fix: Coerce missing PR body to empty string meta(gh): Add a status check for changelogs (#700) ref(server): Manually control concurrent upstream requests (#678) fix(docs): Clarify sooner which mode to choose (#709) chore(config): Remove config for emitting attachment flags (#718) fix(protocol): Fix docs typo (#719) fix(doc): Add missing newlines (#717) ci(release): Add killswitch via issues w/ release-blocker label (#714) fix: Add changelog entry for #712 (#716)
#skip-changelog