chore: reduce realease binary size #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been experimenting along similar lines. In my test, for whatever reason, setting codegen-units to 1 actually slightly increased binary size, have you checked whether it has a positive effect? Also, setting the opt level to |
Swatinem
approved these changes
Nov 2, 2023
|
For me (arm64 macos) the build is smaller with CGU=1 by about 100 KiB. Setting the opt-level to S reduces the size by further 2 MiB and going for Z means another MiB down. |
|
For future reference, here's the size reduction for a release containing this PR (between 25 and 55 % size reduction): |
szokeasaurusrex
added a commit
that referenced
this pull request
Dec 4, 2023
This reverts commit 40f86f6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry CLI is downloaded many times during consumers' CI. Even though the download should be fast in general and the binary size reduction wouldn't have a great effect on individual runs, it does have an effect at the scale it is used at.
Example: macOS arm64 binary size reduction by these changes is about 30 %.