Skip to content

Commit

Permalink
fix: Crash reports not generated on visionOS (#4229)
Browse files Browse the repository at this point in the history
Fix capability checks on visionOS, so crash reports are again generated.

Fixes GH-4217

Co-authored-by: Philipp Hofmann <[email protected]>
  • Loading branch information
miki-shapr and philipphofmann authored Aug 5, 2024
1 parent 2feccaf commit 76c2ac7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
- Guard FramesTracker start and stop (#4224)
- Long-lasting TTID/TTFD spans (#4225). Avoid long TTID spans when the FrameTracker isn't running, which is the case when the app is in the background.
- Missing mach info for crash reports (#4230)
- Crash reports not generated on visionOS (#4229)


### Improvements
Expand Down
8 changes: 4 additions & 4 deletions Sources/Sentry/include/SentryInternalCDefines.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,27 +63,27 @@ typedef unsigned long long bytes;

// Mach APIs are explicitly marked as unavailable in tvOS and watchOS.
// See https://github.com/getsentry/sentry-cocoa/issues/406#issuecomment-1171872518
#if SENTRY_HOST_IOS || SENTRY_HOST_MAC
#if SENTRY_HOST_IOS || SENTRY_HOST_MAC || SENTRY_HOST_VISION
# define SENTRY_HAS_MACH 1
#else
# define SENTRY_HAS_MACH 0
#endif

// signal APIs are explicitly marked as unavailable in watchOS.
// See https://github.com/getsentry/sentry-cocoa/issues/406#issuecomment-1171872518
#if SENTRY_HOST_IOS || SENTRY_HOST_MAC || SENTRY_HOST_TV
#if SENTRY_HOST_IOS || SENTRY_HOST_MAC || SENTRY_HOST_TV || SENTRY_HOST_VISION
# define SENTRY_HAS_SIGNAL 1
#else
# define SENTRY_HAS_SIGNAL 0
#endif

#if SENTRY_HOST_MAC || SENTRY_HOST_IOS
#if SENTRY_HOST_MAC || SENTRY_HOST_IOS || SENTRY_HOST_VISION
# define SENTRY_HAS_SIGNAL_STACK 1
#else
# define SENTRY_HAS_SIGNAL_STACK 0
#endif

#if SENTRY_HOST_MAC || SENTRY_HOST_IOS || SENTRY_HOST_TV
#if SENTRY_HOST_MAC || SENTRY_HOST_IOS || SENTRY_HOST_TV || SENTRY_HOST_VISION
# define SENTRY_HAS_THREADS_API 1
#else
# define SENTRY_HAS_THREADS_API 0
Expand Down

0 comments on commit 76c2ac7

Please sign in to comment.