Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Signals on visionOS #4229

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

miki-shapr
Copy link
Contributor

@miki-shapr miki-shapr commented Aug 3, 2024

📜 Description

Fix capability checks on visionOS.

#skip-changelog

💡 Motivation and Context

This fixes issue #4217

💚 How did you test it?

Crashed the visionOS sample app and verified on the console that the event was sent.

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.434%. Comparing base (649d940) to head (133f0b7).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4229       +/-   ##
=============================================
+ Coverage   91.424%   91.434%   +0.010%     
=============================================
  Files          611       611               
  Lines        49163     49163               
  Branches     17757     17759        +2     
=============================================
+ Hits         44947     44952        +5     
+ Misses        4123      4117        -6     
- Partials        93        94        +1     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649d940...133f0b7. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 😃. Next time please also add an entry to the changelog. I will do that for you this time.

@philipphofmann philipphofmann merged commit 76c2ac7 into getsentry:main Aug 5, 2024
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants