-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Support uint64 in crash reports #2631
Conversation
Add support for uint64 when decoding crash reports.
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
56ec5d0 | 1194.39 ms | 1236.94 ms | 42.55 ms |
3f1be0f | 1208.12 ms | 1225.72 ms | 17.60 ms |
c6504da | 1232.06 ms | 1243.28 ms | 11.22 ms |
feba2be | 1246.67 ms | 1254.64 ms | 7.97 ms |
56ec5d0 | 1236.65 ms | 1261.90 ms | 25.25 ms |
cb2eefe | 1222.04 ms | 1243.04 ms | 21.00 ms |
dc0db9e | 1222.10 ms | 1240.90 ms | 18.80 ms |
b2f82fa | 1237.78 ms | 1256.02 ms | 18.24 ms |
302ee8b | 1194.02 ms | 1223.34 ms | 29.32 ms |
7c5d161 | 1224.38 ms | 1249.66 ms | 25.28 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
56ec5d0 | 20.76 KiB | 414.44 KiB | 393.68 KiB |
3f1be0f | 20.76 KiB | 414.44 KiB | 393.69 KiB |
c6504da | 20.76 KiB | 414.44 KiB | 393.69 KiB |
feba2be | 20.76 KiB | 414.45 KiB | 393.69 KiB |
56ec5d0 | 20.76 KiB | 414.44 KiB | 393.69 KiB |
cb2eefe | 20.76 KiB | 419.62 KiB | 398.86 KiB |
dc0db9e | 20.76 KiB | 419.62 KiB | 398.86 KiB |
b2f82fa | 20.76 KiB | 419.62 KiB | 398.86 KiB |
302ee8b | 20.76 KiB | 419.62 KiB | 398.87 KiB |
7c5d161 | 20.76 KiB | 414.44 KiB | 393.68 KiB |
You're welcome) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some questions and suggestions but no blockers!
} | ||
|
||
- (void)testSerializeDeserializeArrayFloat2 | ||
{ | ||
NSError *error = (NSError *)self; | ||
NSString *expected = @"[-2e-15]"; | ||
id original = [NSArray arrayWithObjects:[NSNumber numberWithFloat:-2e-15f], nil]; | ||
float value = -2e-15f; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a special value in any way? If we're trying to target the smallest representable magnitude, we could try using something like -2 * powf(10, FLT_MIN_10_EXP)
or FLT16_MIN_10_EXP
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, but it was already like that. I don't want to change this in this PR, I only simplified the code a bit.
2da25b7
to
fc91346
Compare
In case you're wondering about the force push from me, I meant to send a fixup commit to one of your other PRs but hadn't paid attention to a failed branch switch locally, so instead committed it to this branch 🙃 All is as it was before I started meddling now. |
Follow up on #2631 to use uint64 instead of double for encoding and decoding crash reports.
Add support for uint64 when decoding crash reports.
Follow up on #2631 to use uint64 instead of double for encoding and decoding crash reports.
📜 Description
Add support for uint64 when decoding crash reports.
💡 Motivation and Context
Applied from kstenerud/KSCrash#375. Thanks, @GLinnik21, for the improvement.
💚 How did you test it?
Unit tests.
📝 Checklist
🔮 Next steps