-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash introduced with uint64 support #2664
Conversation
We forgot to add onUIntegerElement to SentryCrashReportFixer. So the SDK crashed while reading the crash report on the app start. This is fixed now by adding onUIntegerElement. Furthermore, I validated that all SentryCrashJSONDecodeCallbacks now have a mapping to onUIntegerElement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d10ae0c | 1250.02 ms | 1253.74 ms | 3.72 ms |
3a31fc9 | 1237.35 ms | 1249.02 ms | 11.67 ms |
b2f82fa | 1237.78 ms | 1256.02 ms | 18.24 ms |
15b8c61 | 1223.16 ms | 1244.83 ms | 21.67 ms |
b2f82fa | 1236.94 ms | 1262.86 ms | 25.92 ms |
8cb9355 | 1225.23 ms | 1231.22 ms | 5.99 ms |
56ec5d0 | 1194.39 ms | 1236.94 ms | 42.55 ms |
dc0db9e | 1222.10 ms | 1240.90 ms | 18.80 ms |
e71cf92 | 1201.69 ms | 1226.52 ms | 24.83 ms |
302ee8b | 1194.02 ms | 1223.34 ms | 29.32 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d10ae0c | 20.76 KiB | 419.86 KiB | 399.10 KiB |
3a31fc9 | 20.76 KiB | 414.45 KiB | 393.69 KiB |
b2f82fa | 20.76 KiB | 419.62 KiB | 398.86 KiB |
15b8c61 | 20.76 KiB | 419.67 KiB | 398.91 KiB |
b2f82fa | 20.76 KiB | 419.62 KiB | 398.86 KiB |
8cb9355 | 20.76 KiB | 419.70 KiB | 398.95 KiB |
56ec5d0 | 20.76 KiB | 414.44 KiB | 393.68 KiB |
dc0db9e | 20.76 KiB | 419.62 KiB | 398.86 KiB |
e71cf92 | 20.76 KiB | 419.85 KiB | 399.10 KiB |
302ee8b | 20.76 KiB | 419.62 KiB | 398.87 KiB |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2664 +/- ##
==========================================
- Coverage 80.46% 80.40% -0.06%
==========================================
Files 246 246
Lines 22862 22859 -3
Branches 10116 10106 -10
==========================================
- Hits 18395 18380 -15
- Misses 4002 4014 +12
Partials 465 465
Continue to review full report at Codecov.
|
📜 Description
We should have added onUIntegerElement to SentryCrashReportFixer. So the SDK crashed while reading the crash report on the app start. This is fixed now by adding onUIntegerElement. Furthermore, I validated that all SentryCrashJSONDecodeCallbacks now have a mapping to onUIntegerElement.
Related to #2631 and #2642.
Fixes GH-2663
#skip-changelog
💡 Motivation and Context
The SDK crashed while reading the crash report on the app start
💚 How did you test it?
Unit tests and calling crash in the iOS-Swift sample on a real device.
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps