tracePropagationTargets ignores invalid Regex (#1043)

getsentry · Oct 4, 2022 · 0d96d07 · 0d96d07
1 parent 2deb645
commit 0d96d07
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 ### Fixes
 
 - Handle traces sampler exception ([#1040](https://github.com/getsentry/sentry-dart/pull/1040))
+- tracePropagationTargets ignores invalid Regex ([#1043](https://github.com/getsentry/sentry-dart/pull/1043))
 
 ### Features
 

diff --git a/dart/lib/src/utils/tracing_utils.dart b/dart/lib/src/utils/tracing_utils.dart
@@ -46,10 +46,18 @@ bool containsTracePropagationTarget(
     return false;
   }
   for (final target in tracePropagationTargets) {
-    final regExp = RegExp(target, caseSensitive: false);
-    if (url.contains(target) || regExp.hasMatch(url)) {
+    if (url.contains(target)) {
       return true;
     }
+    try {
+      final regExp = RegExp(target, caseSensitive: false);
+      if (regExp.hasMatch(url)) {
+        return true;
+      }
+    } on FormatException {
+      // ignore invalid regex
+      continue;
+    }
   }
   return false;
 }

diff --git a/dart/test/utils/tracing_utils_test.dart b/dart/test/utils/tracing_utils_test.dart
@@ -35,7 +35,15 @@ void main() {
           isTrue);
       expect(
           containsTracePropagationTarget(origins, 'ftp://api.foo.bar:8080/foo'),
-          false);
+          isFalse);
+    });
+
+    test('invalid regex do not throw', () {
+      expect(
+          containsTracePropagationTarget(
+              ['AABB???', '^(http|https)://api\\..*\$'],
+              'http://api.foo.bar:8080/foo'),
+          isTrue);
     });
 
     test('when no origins are defined, returns false for every url', () {