Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracePropagationTargets ignores invalid Regex #1043

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 4, 2022

📜 Description

Ignores invalid regex

💡 Motivation and Context

https://github.com/getsentry/sentry-dotnet/pull/1953/files#r986546256

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2022

Codecov Report

Base: 90.48% // Head: 90.48% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f8576f1) compared to base (2deb645).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1043   +/-   ##
=======================================
  Coverage   90.48%   90.48%           
=======================================
  Files         114      114           
  Lines        3573     3575    +2     
=======================================
+ Hits         3233     3235    +2     
  Misses        340      340           
Impacted Files Coverage Δ
dart/lib/src/utils/tracing_utils.dart 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants