Set User and Breadcrumb from Map

[denrase]

#skip-changelog

📜 Description

Use new Cocoa/Java API to set User and Breadcrumb from map.

💡 Motivation and Context

Closes #1330

💚 How did you test it?

Set user and breadcrumb in sample app and run on iOS & Android.

https://sentry-sdks.sentry.io/issues/3903865215/?project=5428562&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=1h&stream_index=0

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
• I updated the docs if needed
• All tests passing
• No breaking changes

[github-actions]

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against df5cbe7

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.92 ⚠️

Comparison is base (0a82a1e) 90.79% compared to head (df5cbe7) 89.88%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1454      +/-   ##
==========================================
- Coverage   90.79%   89.88%   -0.92%     
==========================================
  Files          61      120      +59     
  Lines        2042     3746    +1704     
==========================================
+ Hits         1854     3367    +1513     
- Misses        188      379     +191     

see 181 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[github-actions]

Android Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	308.36 ms	358.76 ms	50.40 ms
Size	6.15 MiB	7.11 MiB	982.32 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
c1bb00f	303.77 ms	371.88 ms	68.11 ms
7ade5af	341.04 ms	386.84 ms	45.80 ms
abcdba3	354.68 ms	399.04 ms	44.36 ms
b9da046	393.00 ms	455.52 ms	62.52 ms
e66e71e	296.84 ms	345.43 ms	48.59 ms
ae02632	309.16 ms	348.98 ms	39.82 ms
eecbbca	324.37 ms	352.49 ms	28.12 ms
e893df5	310.60 ms	380.58 ms	69.98 ms
5aab4c5	326.12 ms	378.82 ms	52.70 ms
72dfc83	298.62 ms	340.14 ms	41.52 ms

App size

Revision	Plain	With Sentry	Diff
c1bb00f	6.06 MiB	7.09 MiB	1.03 MiB
7ade5af	5.94 MiB	6.95 MiB	1.01 MiB
abcdba3	5.94 MiB	6.95 MiB	1.01 MiB
b9da046	6.06 MiB	7.03 MiB	990.30 KiB
e66e71e	6.06 MiB	7.09 MiB	1.03 MiB
ae02632	5.94 MiB	6.95 MiB	1.01 MiB
eecbbca	5.94 MiB	6.89 MiB	975.78 KiB
e893df5	6.06 MiB	7.09 MiB	1.03 MiB
5aab4c5	6.06 MiB	7.10 MiB	1.04 MiB
72dfc83	5.94 MiB	6.92 MiB	1001.71 KiB

Previous results on branch: feat/user-and-breadcrumb-from-map

Startup times

Revision	Plain	With Sentry	Diff
00385e1	314.73 ms	374.67 ms	59.94 ms
6997864	323.10 ms	372.35 ms	49.24 ms

App size

Revision	Plain	With Sentry	Diff
00385e1	6.15 MiB	7.11 MiB	982.28 KiB
6997864	6.15 MiB	7.11 MiB	982.28 KiB

[marandaneto]

@denrase there's a lint issue:

Superfluous Disable Command Violation: SwiftLint rule 'cyclomatic_complexity' did not trigger a violation in the disabled region; remove the disable command (superfluous_disable_command)

Is there a lint fix for swift lint? can we add it to

sentry-dart/.github/workflows/analyze.yml

Lines 43 to 45 in c3b5126

	- run: dart format .
	- run: dart fix --apply

[github-actions]

iOS Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1221.80 ms	1237.14 ms	15.35 ms
Size	8.29 MiB	9.36 MiB	1.07 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
e893df5	1247.90 ms	1262.31 ms	14.41 ms
b98109e	1254.19 ms	1279.90 ms	25.71 ms
2d3b03d	1258.19 ms	1272.69 ms	14.50 ms
62de927	1242.46 ms	1246.11 ms	3.65 ms
11fb408	1256.14 ms	1283.51 ms	27.37 ms
fdac48a	1281.92 ms	1300.22 ms	18.31 ms
69670c9	1269.18 ms	1288.69 ms	19.51 ms
ad69abc	1259.00 ms	1261.60 ms	2.60 ms
3f23617	1261.93 ms	1286.10 ms	24.17 ms
689d2fd	1257.71 ms	1265.16 ms	7.45 ms

App size

Revision	Plain	With Sentry	Diff
e893df5	8.09 MiB	9.07 MiB	1001.04 KiB
b98109e	8.10 MiB	9.17 MiB	1.08 MiB
2d3b03d	8.10 MiB	9.07 MiB	1000.83 KiB
62de927	8.29 MiB	9.37 MiB	1.08 MiB
11fb408	8.10 MiB	9.08 MiB	1004.36 KiB
fdac48a	8.10 MiB	9.08 MiB	1004.37 KiB
69670c9	8.10 MiB	9.08 MiB	1004.49 KiB
ad69abc	8.10 MiB	9.08 MiB	1004.37 KiB
3f23617	8.16 MiB	9.17 MiB	1.01 MiB
689d2fd	8.10 MiB	9.16 MiB	1.06 MiB

Previous results on branch: feat/user-and-breadcrumb-from-map

Startup times

Revision	Plain	With Sentry	Diff
6997864	1229.31 ms	1240.96 ms	11.65 ms
00385e1	1227.45 ms	1234.37 ms	6.93 ms

App size

Revision	Plain	With Sentry	Diff
6997864	8.29 MiB	9.36 MiB	1.07 MiB
00385e1	8.29 MiB	9.36 MiB	1.07 MiB

[denrase]

@marandaneto It seams that the commit script is not run anymore. Seems that $GITHUB_HEAD_REF is null somehow even on a branch? Maybe because it's a draft PR? Didn't find this documented. Trying to run with different vars.