Cleaning up mermaid code and made it a bit more readable in dark mode #11726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 248 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
antonpirker
commented
Nov 4, 2024
src/components/mermaid.tsx
Outdated
| mermaid.initialize({startOnLoad: false}); | ||
| mermaid.initialize({ | ||
| startOnLoad: false, | ||
| theme: 'neutral', |
There was a problem hiding this comment.
@chargome It would be great to set here the theme default if light mode is activated and the dark theme if the dark mode is activated.
|
I will just merge this, and then create a separate issue for the switching problem. So we can tackle this whenever there is time! @chargome can you review/approve this PR please? |
chargome
approved these changes
Nov 5, 2024
martinhaintz
pushed a commit
that referenced
this pull request
Nov 5, 2024
* master: (213 commits) Remove feature flag documentation from issue details page (#11734) docs(insights): Remove EA note from Queries re: MongoDB (#11735) docs(nuxt): `piniaIntegration` in Nuxt (#11684) feat(flags): Add OpenFeature and LaunchDarkly integration documentation (#11675) Cleaning up mermaid code and made it a bit more readable in dark mode (#11726) docs(scopes): Add graphics for scope forking (#11702) Unreal Engine plugin documentation update (#11625) Bump API schema to 25e528ff (#11728) Bump API schema to 12bd311c (#11725) fix dark theme resolution (#11718) Update sign in to go to sentry (#11723) getsentry/relay@4bdad17 API examples syntax highlighting (#11715) feat: Convert mermaid code blocks to SVGs client side (#11690) Trace context is required for transactions (#11456) deps: Bump SDK to 8.36.0 (#11696) getsentry/relay@2e2587c MAUI screenshot `SetBeforeScreenshotCapture`(#11672) Add CSS rule to fix color of bold links (#11707) Fix small typo on web-vitals-concepts (#11706) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
neutralmermaid theme, that is somewhat readable in light and dark mode.Preview
New graph theme:
https://develop-docs-git-antonpirker-mermaid-cleanup.sentry.dev/application/architecture/
Documentation on how to use it:
https://sentry-docs-git-antonpirker-mermaid-cleanup.sentry.dev/contributing/pages/charts-diagrams/
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES