Unreal Engine plugin documentation update #11625
Conversation
|
@tustanivsky is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Thanks for updating those!
There seem to be 2 links that lead to non-existing pages
❌ Found 2 404s across 1 page
🌐 http://localhost:3000/platforms/unreal/tracing
- [TracesSampler](/platforms/unreal/configuration/sampling/#setting-a-sampling-function)
- [sample transactions](/platforms/unreal/configuration/sampling/#sampling-transaction-events)
Good catch - we were entirely missing the |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
tustanivsky
force-pushed
the
unreal-engine
branch
from
42b56ba
to
2034c7c
Compare
There was a problem hiding this comment.
I do wish we could "gamify" the sample.
platform-includes/distributed-tracing/custom-instrumentation/unreal.mdx
Outdated
Show resolved
Hide resolved
platform-includes/performance/enable-manual-instrumentation/unreal.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Krawiec <[email protected]>
Co-authored-by: Alex Krawiec <[email protected]>
…real.mdx Co-authored-by: Alex Krawiec <[email protected]>
…nreal.mdx Co-authored-by: Alex Krawiec <[email protected]>
Co-authored-by: Alex Krawiec <[email protected]>
Co-authored-by: Alex Krawiec <[email protected]>
tustanivsky
force-pushed
the
unreal-engine
branch
from
5ca9e93
to
c6d0464
Compare
|
I've approved the vercel build, lets see |
| - `sentry-trace` | ||
| - `baggage` | ||
|
|
||
| If you run any JavaScript applications in your distributed system, make sure that those two headers are added to your CORS allowlist and won't be blocked or stripped by your proxy servers, gateways, or firewalls. |
There was a problem hiding this comment.
We should prob fix this docs-wide, right? A Flutter/.NET/Kotlin/Rust app running on the browser (e.g: wasm) also has this concern. While a JS app on NodeJS doesn't.
@chargome does my statement check out?
| If you run any JavaScript applications in your distributed system, make sure that those two headers are added to your CORS allowlist and won't be blocked or stripped by your proxy servers, gateways, or firewalls. | |
| If you run any browser applications in your distributed system, make sure that those two headers are added to your CORS allowlist and won't be blocked or stripped by your proxy servers, gateways, or firewalls. |
There was a problem hiding this comment.
@bruno-garcia yes, we have docs for (browser) JS on that here: https://docs.sentry.io/platforms/javascript/tracing/trace-propagation/dealing-with-cors-issues/
platform-includes/performance/default-sampling-context-platform/unreal.mdx
Outdated
Show resolved
Hide resolved
platform-includes/performance/sampling-function-intro/unreal.mdx
Outdated
Show resolved
Hide resolved
| virtual bool Sample_Implementation(USentrySamplingContext* samplingContext, float& samplingValue) override | ||
| { | ||
| const FString& path = | ||
| *samplingContext->GetCustomSamplingContext().Find("__HttpPath"); |
There was a problem hiding this comment.
Can we translate this to something that resonates more with an Unreal Game?
__HttpPath is IIRC what we have on ASP.NET Core.
Do we create transactions with any additional context in the SDK that we can use here in the example?
| *samplingContext->GetCustomSamplingContext().Find("__HttpPath"); | |
| *samplingContext->GetCustomSamplingContext().Find("StartGame"); |
There was a problem hiding this comment.
I've made an attempt to "gamify" this example by determining the sample rate based on a match's game mode. Please let me know if that makes sense
Co-authored-by: Bruno Garcia <[email protected]>
…tation.mdx Co-authored-by: Bruno Garcia <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>
…m/unreal.mdx Co-authored-by: Bruno Garcia <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>
|
Troubleshooting some vercel issues with @bitsandfoxes, I've authorized the vercel changes |
* master: (213 commits) Remove feature flag documentation from issue details page (#11734) docs(insights): Remove EA note from Queries re: MongoDB (#11735) docs(nuxt): `piniaIntegration` in Nuxt (#11684) feat(flags): Add OpenFeature and LaunchDarkly integration documentation (#11675) Cleaning up mermaid code and made it a bit more readable in dark mode (#11726) docs(scopes): Add graphics for scope forking (#11702) Unreal Engine plugin documentation update (#11625) Bump API schema to 25e528ff (#11728) Bump API schema to 12bd311c (#11725) fix dark theme resolution (#11718) Update sign in to go to sentry (#11723) getsentry/relay@4bdad17 API examples syntax highlighting (#11715) feat: Convert mermaid code blocks to SVGs client side (#11690) Trace context is required for transactions (#11456) deps: Bump SDK to 8.36.0 (#11696) getsentry/relay@2e2587c MAUI screenshot `SetBeforeScreenshotCapture`(#11672) Add CSS rule to fix color of bold links (#11707) Fix small typo on web-vitals-concepts (#11706) ...
This PR introduces the following changes to Unreal Engine plugin docs: