feat(java): Add automatic and custom performance metrics doc #5604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@markushi usually you can add the entire mobile team to reviewers and whoever approves first wins :) |
krystofwoldrich
approved these changes
Oct 6, 2022
|
LGTM 👍 but we need to release the SDK 6.5.0 first, so I'd hold this off until it's released. Maybe convert it into a draft to not merge accidentally |
romtsn
approved these changes
Oct 6, 2022
|
|
While we are here, could we add a page that describes our automatic performance metrics for Android, under here: https://github.com/getsentry/sentry-docs/tree/master/src/platform-includes/performance/automatic-performance-metrics (you can follow the same format as JavaScript) |
|
@AbhiPrasad sounds like a good idea, let me take care of this 👍
|
markushi
changed the title
imatwawana
reviewed
Oct 6, 2022
src/platform-includes/performance/automatic-performance-metrics/android.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/performance/automatic-performance-metrics/android.mdx
Outdated
Show resolved
Hide resolved
…s/android.mdx Co-authored-by: Isabel <[email protected]>
…s/android.mdx Co-authored-by: Isabel <[email protected]>
philipphofmann
approved these changes
Oct 10, 2022
src/platform-includes/performance/automatic-performance-metrics/android.mdx
Outdated
Show resolved
Hide resolved
src/platforms/common/performance/instrumentation/performance-metrics.mdx
Show resolved
Hide resolved
…s/android.mdx Co-authored-by: Philipp Hofmann <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing API doc for custom performance metrics, including java and kotlin example code.
See getsentry/sentry-java#2260 for the relevant SDK implementation.
@romtsn who else should be reviewing this PR?