Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apple): Add custom performance metrics #5629

Merged
merged 6 commits into from
Oct 14, 2022

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Oct 11, 2022

Only merge after releasing Cocoa 7.28.0. Related Cocoa PR getsentry/sentry-cocoa#2268.
This PR is similar to #5604.

Only merge after releasing Cocoa 7.28.0. Related Cocoa PR
getsentry/sentry-cocoa#2268.
@vercel
Copy link

vercel bot commented Oct 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Oct 12, 2022 at 7:19AM (UTC)

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, made a few formatting edits.

@imatwawana
Copy link
Contributor

Hey Philipp, thanks for leaving this for us to review. @lizokm is our new docs manager!

@philipphofmann philipphofmann merged commit 95c4100 into master Oct 14, 2022
@philipphofmann philipphofmann deleted the feat/apple-custom-measurements branch October 14, 2022 11:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants