fix(tracing): Protect from concurrent reads/writes to Span Tags, Contexts, Data #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exts, Data Span.SetTag(), Span.SetData(), Span.SetContext(), and Span.toEvent() read and write to underlying Span.Tags, Span.Data, and Span.contexts maps, which might read to panics if the operations are not synchronized. This PR adds a mutex that makes sure that those methods are not executed in parallel.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #609 +/- ##
==========================================
- Coverage 79.92% 79.91% -0.02%
==========================================
Files 38 38
Lines 3861 3873 +12
==========================================
+ Hits 3086 3095 +9
- Misses 669 671 +2
- Partials 106 107 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
cleptric
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Span.SetTag(), Span.SetData(), Span.SetContext(), and Span.toEvent() read and write to underlying Span.Tags, Span.Data, and Span.contexts maps, which might read to panics if the operations are not synchronized.
This PR adds a mutex that makes sure that those methods are not executed in parallel.
Note: this doesn't protect from the situation when Set* methods are called on a span that has already been finished. It's tracked separately in #587