Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracing): Protect from concurrent reads/writes to Span Tags, Contexts, Data #609

Merged
merged 5 commits into from
Apr 4, 2023
Merged

fix(tracing): Protect from concurrent reads/writes to Span Tags, Contexts, Data #609

merged 5 commits into from
Apr 4, 2023

Commits on Mar 29, 2023

  1. fix(tracing): Protect from concurrent reads/writes to Span Tags, Cont… 

    …exts, Data

Span.SetTag(), Span.SetData(), Span.SetContext(), and Span.toEvent() read and
write to underlying Span.Tags, Span.Data, and Span.contexts maps,
which might read to panics if the operations are not synchronized.

This PR adds a mutex that makes sure that those methods are not executed
in parallel.
    @tonyo
    tonyo committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    2b44350 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. Merge branch 'master' into tonyo/span-tags-context-data-concurr

    @tonyo
    tonyo authored Apr 3, 2023
    Configuration menu
    Copy the full SHA
    f9e9f3f View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Use Span pointers in tests

    @tonyo
    tonyo committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    be0bcd5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into tonyo/span-tags-context-data-concurr

    @tonyo
    tonyo authored Apr 4, 2023
    Configuration menu
    Copy the full SHA
    d3810e0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into tonyo/span-tags-context-data-concurr

    @tonyo
    tonyo authored Apr 4, 2023
    Configuration menu
    Copy the full SHA
    db897d6 View commit details
    Browse the repository at this point in the history