feat: add linux distributions to os context #963
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #963 +/- ##
==========================================
+ Coverage 82.58% 82.69% +0.11%
==========================================
Files 53 53
Lines 7505 7536 +31
Branches 1206 1215 +9
==========================================
+ Hits 6198 6232 +34
+ Misses 1196 1194 -2
+ Partials 111 110 -1 |
|
The failing Mingw test is unrelated to the change (a change in the GHA runner image requires us to install |
…solving to memcpy
supervacuus
force-pushed
the
feat/add_linux_distros_to_os_context
branch
from
700a65a
to
44866bb
Compare
|
again, failing test here is due to: #968 |
This is a hugely hypothetical target, since the max values are far beyond all the test data we currently observed, but still.
...to separate parsing/output from buffer management.
Users of the Native SDK also want to search for the Linux distributions their events came from: getsentry/sentry-native#943 The corresponding PRs to * develop docs: getsentry/develop#1227 * relay: getsentry/relay#3443 * Native SDK: getsentry/sentry-native#963
Users of the Native SDK also want to search for the Linux distributions their events came from: getsentry/sentry-native#943 The corresponding PRs to * develop docs: getsentry/develop#1227 * relay: getsentry/relay#3443 * Native SDK: getsentry/sentry-native#963
|
PR is on hold until the context format is clarified. Nested context formats with three layers are unacceptable for the backend to search, so we either change the format in the SDK or map it locally in the sentry backend. Since the format was at the core of how to add this feature from the start, it is best to change the format in the SDK (and with it, in the develop-docs, relay, and sentry backend). This is currently deprioritized. |
Fixes #943.
This adds Linux distribution meta-data to the os context as follows:
Only
nameandversionshould be indexed.Further steps required before we merge/release this:
nameandversion: Make os.distribution searchable sentry#69865distribution_nameinstead ofdistribution.name, etc.)master: fix: 404 links in develop-docs sentry-docs#10768)