fix: exclude custom_logger from transport test-suite #968
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A race in one of our unit tests was uncovered, probably due to recent fixes and updates in our
ASAN
runner config (#965), which may have influenced the timing.The
custom_logger
test was written for a single-threaded configuration, but since it was automatically added to the transport test suite, the logger in this test would also be called from multiple threads, now leading to unexpected sequences in its assertions:The fix for this is a trivial exclusion from the transport test suite, but the fact that the race existed for several years in the tests is an excellent reason to add a note to the docs stating that synchronization is required in custom loggers 😅.
#skip-changelog