Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude custom_logger from transport test-suite #968

Merged

Conversation

supervacuus
Copy link
Collaborator

A race in one of our unit tests was uncovered, probably due to recent fixes and updates in our ASAN runner config (#965), which may have influenced the timing.

The custom_logger test was written for a single-threaded configuration, but since it was automatically added to the transport test suite, the logger in this test would also be called from multiple threads, now leading to unexpected sequences in its assertions:

The fix for this is a trivial exclusion from the transport test suite, but the fact that the race existed for several years in the tests is an excellent reason to add a note to the docs stating that synchronization is required in custom loggers 😅.

#skip-changelog

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.76%. Comparing base (f4b9cfa) to head (e9fe055).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #968      +/-   ##
==========================================
- Coverage   83.70%   82.76%   -0.95%     
==========================================
  Files          51       53       +2     
  Lines        6961     7444     +483     
  Branches     1093     1198     +105     
==========================================
+ Hits         5827     6161     +334     
- Misses       1030     1173     +143     
- Partials      104      110       +6     

@supervacuus supervacuus merged commit fda905a into master Mar 25, 2024
20 checks passed
@supervacuus supervacuus deleted the fix/exclude_custom_logger_from_transport_test_suite branch March 25, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants