Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use php-http/discovery": "^1.15 #1504

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Use php-http/discovery": "^1.15 #1504

merged 1 commit into from
Mar 23, 2023

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Mar 23, 2023

From #1459

This is a follow up of #1429
Since this PR and our discussion at SymfonyCon, I've been working on moving those ideas to "php-http/discovery", and v1.15.0 has just been tagged 🎉
By bumping to v1.15.0, we keep compatibility with PHP >= 7.1 and composer v1 & v2, but we also benefit from:

@@ -24,15 +24,13 @@
"ext-json": "*",
"ext-mbstring": "*",
"guzzlehttp/promises": "^1.4",
"guzzlehttp/psr7": "^1.8.4|^2.1.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still required inside GuzzleTracingMiddleware, but so is GuzzleHttp\Exception\RequestException, which we do not require. Hence people need to require composer require guzzlehttp/guzzle already, so removing it is fine imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants