Add generic Psr17Factory

[nicolas-grekas]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Related tickets	-
Documentation	php-http/documentation#303
License	MIT

This PR ports WellKnownPsr17Factory to this repository.

This approach should make it even simpler to write generic PSR17-consuming code.
It would also make the package compatible with factories declared as default values.

Last but not least, the implementation in Psr17Factory provides two additional methods

• Psr17Factory::createServerRequestFromGlobals()
• Psr17Factory::createUriFromGlobals()

Providing these two methods provides true portability of PSR-7 implementations.
An example that shows this is missing is Sentry's RequestFetcher, which is currently coupled to guzzlehttp/psr7 because of the call to ServerRequest::fromGlobals().

Example Usage

Inline:

$factory = new Psr17Factory();

// Now we can call any PSR-17 method, e.g.
$factory->createRequest();

As default value on PHP8+:

class Foo
{
    public function __construct(
        private RequestFactoryInterface $requestFactory = new Psr17Factory(),
    ) {
        //...
    }
}

To Do

• Updated CHANGELOG.md
• Documentation pull request created
• Fix tests

[dbu]

interesting. it does not directly have to do with discovery, not convinced if it fits into this repository.

looking at what we currently provide, i don't see a clear home for this. but like we have php-http/message about psr 7 things, we could do a php-http/factory repository for it?

i think i would prefer that over having it as part of discovery. wdyt? i could set up that repository and give you commit rights if you want.

[nicolas-grekas]

it does not directly have to do with discovery, not convinced if it fits into this repository.

Arf. To me, discovery is the package where this makes most sense, because that class is using discovery, and because it fills the same need - decoupling to any specific PSR-17 implem. Making a separate package would just make maintenance harder and slow down adoption to me.

[dbu]

thanks for the discussion in slack @nicolas-grekas , now i got what it does. its a decorator around the findX methods that provides you with an all-of-psr17 factory that autodiscovers its things if needed but accepts constructor arguments when autodiscovery is not wanted.

yep, that fits into this package then.

[nicolas-grekas]

I just pushed tests for the *FromGlobals() methods. PR is ready on my side.

[dbu]

great, thanks!