Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rails 7.2 on CI #2382

Merged
merged 2 commits into from
Aug 19, 2024

Use Rails config to silence deprecation

3a4836f
Select commit
Loading
Failed to load commit list.
Merged

Support Rails 7.2 on CI #2382

Use Rails config to silence deprecation
3a4836f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 17, 2024 in 0s

98.69% (-0.01%) compared to 22f2a3a, passed because coverage increased by -0.01% when compared to adjusted base (98.70%)

View this Pull Request on Codecov

98.69% (-0.01%) compared to 22f2a3a, passed because coverage increased by -0.01% when compared to adjusted base (98.70%)

Details

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.69%. Comparing base (22f2a3a) to head (3a4836f).

Files Patch % Lines
sentry-rails/spec/sentry/generator_spec.rb 75.00% 1 Missing ⚠️
sentry-rails/spec/sentry/rails/client_spec.rb 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2382      +/-   ##
==========================================
- Coverage   98.70%   98.69%   -0.01%     
==========================================
  Files         210      210              
  Lines       13904    13912       +8     
==========================================
+ Hits        13724    13731       +7     
- Misses        180      181       +1     
Components Coverage Δ
sentry-ruby 99.08% <ø> (+<0.01%) ⬆️
sentry-rails 97.34% <84.61%> (-0.09%) ⬇️
sentry-sidekiq 97.01% <ø> (ø)
sentry-resque 96.79% <ø> (ø)
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-rails/spec/dummy/test_rails_app/app.rb 92.75% <100.00%> (+0.10%) ⬆️
sentry-rails/spec/sentry/generator_spec.rb 97.36% <75.00%> (-2.64%) ⬇️
sentry-rails/spec/sentry/rails/client_spec.rb 97.05% <85.71%> (-2.95%) ⬇️

... and 1 file with indirect coverage changes