New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor build scripts for plugin dependencies #41

Closed

tustanivsky opened this issue Jul 20, 2022 · 0 comments · Fixed by #63

Labels

Feature

Collaborator

tustanivsky commented Jul 20, 2022 •

edited

Loading

There is some code duplication in scripts that are used for updating plugin dependencies.

"Maybe these three scripts into one, with config being the input script, and all of the sourcing the common script. Removes duplication a bit. See for example https://github.com/getsentry/sentry-react-native/blob/main/scripts/update-wizard.sh that's the "updater.yml" target script and itself includes a common update-package-json.sh"

Originally posted by @vaind in #35 (comment)

The text was updated successfully, but these errors were encountered:

tustanivsky added Platform: Unreal Feature labels

vaind mentioned this issue

Remove dependency binaries #63

Merged

vaind closed this as completed in #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment